change suspicious_operation_groupings to work on the HIR instead of the AST
#15443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for decf7d6
This comment will be updated if you push new changes |
|
From what i see, it's not. I'll have to figure that out. I think it's just a case of checking whether the expression (so, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
suspicious_operation_groupings]: changed the lint to work on the HIR and included a check for the existence of a suggested field.fixes #7086
As a short message, i have discovered a potential false positive, however i am not sure whether it should be part of this PR.
(I've also made a slight mistake with the last commit in this PR, i hope it doesn't affect anything. I'm a bit new to this)